Skip to content

Conversation

xaviraol
Copy link
Contributor

@xaviraol xaviraol commented Dec 19, 2019

@panjiyudasetya I started already, I had to set up everything with Android Studio to see in which imports and things I was getting the errors, but it went better than expected.

Basically I did import all erasmus-android files under the java/nl/sense/rninputkit folder.
I addressed all the import names and some minor other things that I could figure out, but still some things missing:

  • The most important one, input-kit is still not added. So building now throws hundreds of errors of "package nl.sense_os.input_kit.bla bla" does not exist". I guess that will be solved once you add it 😎 .
  • The other thing related to inputkit is that it requires samsung health package or something, and I had absolutely no idea on how to add this to the project. Regarding that, do we still want to add it in our project? Because we are not using it, no?
  • The other problems I had are with the R.java. Apparently this file is autogenerated and it's about resources, no? I couldn't find a way to set it up.. some keys in AndroidManifest and then some resources like strings.xml and stuff like this, no?
  • The last but not least errors I had were related with React itself. One because of missing HeadlessJsTaskService and the other ones some complaints in the HealthBridge file..

Once we add the Inputkit somehow, I don't have the feeling that the rest will be complex, but let's see. Let's see if you have some time tomorrow to address what is left. If not I'll slowly continue with it 💪

Tagging @umarniz as well in case he has some free time.

PS: using Android Studio helped a lot detecting all the missing / wrong things I was doing, I think is the first time that I use it successfully 😱 😱

@xaviraol
Copy link
Contributor Author

xaviraol commented Dec 20, 2019

I continued a bit today and I actually managed to build the app in Android! 🎉

The problem that I encountered is that I get the error INPUT_KIT_NOT_CONNECTED when I try to use it, but I think it's close. To keep this branch clean, I added all the last changes in setting-up-android-xavi (this is the diff between that branch and this one: setting-up-android...setting-up-android-xavi)

@panjiyudasetya
Copy link
Collaborator

Good jooob @xaviraol 🎉 🎉 🎉
Finally you can contribute mooore in Android domaaaain 🕺🕺🕺
I only add a slight update to add debug keystore for the example project and modify signing config a bit on the gradle.

The rest are only registering this example package through the Fitness API in developer console. I would like to test this PR a bit more. And I'll merge it when I'm done testing 😉

@xaviraol xaviraol merged commit 9b5fe2e into master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants